Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add exports and exportedBindings to Module class #4731

Merged
merged 12 commits into from Dec 5, 2022

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Nov 29, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

@lukastaegert Could you recommend a file location where I can write tests for this pr?

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

resolves #4721

Description

expose exports and exportedBindings for use in some hooks.

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #4731 (c0462a3) into master (9900792) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4731   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files         217      217           
  Lines        7690     7698    +8     
  Branches     2126     2128    +2     
=======================================
+ Hits         7616     7624    +8     
  Misses         24       24           
  Partials       50       50           
Impacted Files Coverage Δ
src/ExternalModule.ts 100.00% <ø> (ø)
src/Module.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/ExternalModule.ts Outdated Show resolved Hide resolved
@lukastaegert
Copy link
Member

Could you recommend a file location where I can write tests for this pr?

I think for this specific topic, the existing test changes should cover it.

src/Module.ts Outdated Show resolved Hide resolved
src/Module.ts Outdated Show resolved Hide resolved
src/Module.ts Outdated Show resolved Hide resolved
@lukastaegert
Copy link
Member

Now to finish the feature, we need to add it to the documentation. In this case, it is only necessary in the section about this.getModuleInfo in 05-plugin-development.md.

@TrickyPi
Copy link
Member Author

TrickyPi commented Dec 5, 2022

Done, if some descriptions are inaccurate, plz let me know.

@lukastaegert lukastaegert merged commit de6675b into rollup:master Dec 5, 2022
@TrickyPi TrickyPi deleted the feat/add-exports-info branch December 5, 2022 10:09
@lukastaegert
Copy link
Member

lukastaegert commented Dec 5, 2022

Thank you very much for your work on this and sticking with me! Will put this into a release. If you are interested, I put the "PR welcome" label on some of the most recent issues. On some of them, I added a comment what I would expect the "fix" should be. If you are interested, just pick any of them. Feel free to ping me if you want further guidance. Again, thank you so much for your work so far!

@TrickyPi
Copy link
Member Author

TrickyPi commented Dec 5, 2022

Wow, I'm interested in contributing to rollup, I will look at these issues. I learned a lot from this PR with your guidance, thank you very much 😄.

@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.6.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose module and bundle exports from hooks
3 participants