Improve chunk assignment performance #4736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#improve-chunk-assignment-performanceor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4736 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 217 217
Lines 7703 7707 +4
Branches 2130 2133 +3
=======================================
+ Hits 7629 7633 +4
Misses 24 24
Partials 50 50
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lukastaegert
force-pushed
the
improve-chunk-assignment-performance
branch
2 times, most recently
from
8c1e9f0
to
9b18ffc
Compare
Also generates dynamicImportsByEntry that will help us to track already loaded modules more efficiently.
lukastaegert
force-pushed
the
improve-chunk-assignment-performance
branch
from
9b18ffc
to
dc0f100
Compare
|
This PR has been released as part of rollup@3.7.2. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This refactors the chunk generation algorithm to hopefully improve the performance for very large projects. Basically instead of doing an ad-hoc reverse search for each module in each dynamic chunk if it may already be in memory when the chunk is loaded, when pre-create a table of modules that are in memory for each dynamic chunk. It has still some run time complexity, but my hope is that it will perform much better than the old algorithm.