Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide json hint when importing a no export json file #4741

Merged
merged 3 commits into from Dec 8, 2022

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Dec 8, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #4635

Description

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #4741 (c36bd3f) into master (156f4d1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4741   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files         217      217           
  Lines        7701     7703    +2     
  Branches     2129     2130    +1     
=======================================
+ Hits         7627     7629    +2     
  Misses         24       24           
  Partials       50       50           
Impacted Files Coverage Δ
src/utils/error.ts 99.47% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@lukastaegert lukastaegert enabled auto-merge (squash) December 8, 2022 20:15
@lukastaegert lukastaegert merged commit cc54a24 into rollup:master Dec 8, 2022
@TrickyPi TrickyPi deleted the fix/enhance-error branch December 9, 2022 05:07
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.7.1. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No useful error provided when importing json array file without @rollup/plugin-json
3 participants