Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide hashed file name when using this.getFileName in generateBundle #4747

Merged
merged 1 commit into from Dec 11, 2022

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

I completely forgot about this.getFileName with the new hashing logic. Now you get the file name with the hash instead of the placeholder in generateBundle.

@github-actions
Copy link

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4744-correct-getFileName-generate-bundle

or load it into the REPL:
https://rollupjs.org/repl/?pr=4747

@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #4747 (caa47f7) into master (2effc19) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4747      +/-   ##
==========================================
- Coverage   99.03%   99.03%   -0.01%     
==========================================
  Files         217      217              
  Lines        7707     7706       -1     
  Branches     2133     2132       -1     
==========================================
- Hits         7633     7632       -1     
  Misses         24       24              
  Partials       50       50              
Impacted Files Coverage Δ
src/Chunk.ts 100.00% <100.00%> (ø)
src/utils/FileEmitter.ts 100.00% <100.00%> (ø)
src/utils/renderChunks.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit a0d4d69 into master Dec 11, 2022
@lukastaegert lukastaegert deleted the gh-4744-correct-getFileName-generate-bundle branch December 11, 2022 15:22
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.7.3. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't access emitted filename within generateBundle
2 participants