Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arbitrary module namespace identifiers #4770

Merged
merged 2 commits into from Dec 28, 2022

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This adds support for ES2022 arbitrary module namespace identifiers, i.e.

import { '=>' as foo } from './foo.js';
export { foo as '=>' };
export { '=>' as '<=' } from './foo.js';

@github-actions
Copy link

github-actions bot commented Dec 27, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4322-arbitrary-module-namespace-identifiers

or load it into the REPL:
https://rollupjs.org/repl/?pr=4770

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #4770 (b9566a0) into master (57fa7e0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4770      +/-   ##
==========================================
- Coverage   99.03%   99.03%   -0.01%     
==========================================
  Files         217      217              
  Lines        7774     7773       -1     
  Branches     2154     2159       +5     
==========================================
- Hits         7699     7698       -1     
  Misses         24       24              
  Partials       51       51              
Impacted Files Coverage Δ
src/Module.ts 100.00% <100.00%> (ø)
src/ast/nodes/NodeType.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit 5aa1cce into master Dec 28, 2022
@lukastaegert lukastaegert deleted the gh-4322-arbitrary-module-namespace-identifiers branch December 28, 2022 05:57
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.9.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES2022: arbitrary module namespace names
2 participants