Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update magic-string and adjust types. #4846

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

bmeurer
Copy link
Contributor

@bmeurer bmeurer commented Feb 8, 2023

The type of sourcesContent changed to allow for null elements, and rollup needs to be adjusted to that as well.

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Description

This PR updates magic-string past 0.27, addressing the breaking change in the sourcesContent type (going from string[] to (string|null)[]).

@netlify
Copy link

netlify bot commented Feb 8, 2023

Deploy Preview for rollupjs ready!

Name Link
🔨 Latest commit 28a68ec
🔍 Latest deploy log https://app.netlify.com/sites/rollupjs/deploys/63e9e1d753ab350008c427c7
😎 Deploy Preview https://deploy-preview-4846--rollupjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bmeurer
Copy link
Contributor Author

bmeurer commented Feb 8, 2023

I'll update this PR as soon as @Rich-Harris cuts a new release of magic-string that contains the updated type definitions.

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #4846 (28a68ec) into master (45d5d53) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4846   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         219      219           
  Lines        7887     7887           
  Branches     2184     2184           
=======================================
  Hits         7808     7808           
  Misses         26       26           
  Partials       53       53           
Impacted Files Coverage Δ
src/utils/collapseSourcemaps.ts 90.42% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert
Copy link
Member

I wonder why Node 14 does not want to install magic-string from Github

@bmeurer
Copy link
Contributor Author

bmeurer commented Feb 9, 2023

I pinged @Rich-Harris to cut a release, so we can wait until that happens.

The type of `sourcesContent` changed to allow for `null` elements, and
rollup needs to be adjusted to that as well.
@bmeurer
Copy link
Contributor Author

bmeurer commented Feb 13, 2023

Updated to the latest release version of magic-string, which brings the typing fixes as well as the x_google_ignoreList support (which is not utilized as part of this PR).

This is ready to land now.

@lukastaegert lukastaegert enabled auto-merge (squash) February 14, 2023 05:43
@lukastaegert lukastaegert merged commit 010ed63 into rollup:master Feb 14, 2023
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.15.1-1. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@3.15.1-1 or npm install rollup@beta. It will likely become part of a regular release later.

@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.16.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants