Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set a correct node location for static blocks #4898

Merged
merged 3 commits into from Mar 10, 2023

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Mar 9, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #4895

Description

@TrickyPi TrickyPi force-pushed the fix/4895 branch 2 times, most recently from 7faecfb to 83a22fa Compare March 9, 2023 17:04
@TrickyPi TrickyPi changed the title fix: get a correct node location for unincluded body in inline static blocks fix: set a correct node location for static blocks Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #4898 (1e224d5) into master (7bff18c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4898   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         221      221           
  Lines        8025     8026    +1     
  Branches     2209     2209           
=======================================
+ Hits         7946     7947    +1     
  Misses         26       26           
  Partials       53       53           
Impacted Files Coverage Δ
src/ast/nodes/StaticBlock.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Mar 10, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install TrickyPi/rollup#fix/4895

or load it into the REPL:
https://deploy-preview-4898--rollupjs.netlify.app/repl/?pr=4898

Copy link
Member

@lukastaegert lukastaegert left a comment

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍

@lukastaegert lukastaegert merged commit 46676a4 into rollup:master Mar 10, 2023
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.19.1. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treeshaking breaks static blocks in some cases
3 participants