Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically force close Rollup when done #4969

Merged
merged 1 commit into from May 2, 2023
Merged

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

As many people were reporting issues, this implements the proposed force quite via process.exit that some proposed.

@vercel
Copy link

vercel bot commented May 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2023 6:30am

@github-actions
Copy link

github-actions bot commented May 1, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#process-exit

or load it into the REPL:
https://rollup-hwwuld6pm-rollup-js.vercel.app/repl/?pr=4969

@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #4969 (fd44373) into master (64870c3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4969      +/-   ##
==========================================
+ Coverage   98.96%   98.99%   +0.02%     
==========================================
  Files         222      222              
  Lines        8123     8123              
  Branches     2237     2237              
==========================================
+ Hits         8039     8041       +2     
+ Misses         29       28       -1     
+ Partials       55       54       -1     
Impacted Files Coverage Δ
cli/cli.ts 50.00% <100.00%> (ø)
cli/run/index.ts 100.00% <100.00%> (ø)
cli/run/watch-cli.ts 88.88% <100.00%> (+2.77%) ⬆️

@lukastaegert lukastaegert merged commit 5f9152f into master May 2, 2023
12 checks passed
@lukastaegert lukastaegert deleted the process-exit branch May 2, 2023 04:14
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.21.3. You can test it via npm install rollup.

lukastaegert added a commit that referenced this pull request May 20, 2023
@lukastaegert
Copy link
Member Author

I will revert this change as it caused too many issues elsewhere, see #5004.

lukastaegert added a commit that referenced this pull request May 20, 2023
lukastaegert added a commit that referenced this pull request May 21, 2023
lukastaegert added a commit that referenced this pull request May 21, 2023
lukastaegert added a commit that referenced this pull request May 21, 2023
* Do not force quit Rollup or close stdout

reverts #4969, #4983

* Avoid memory leaks via beforeExit listeners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rollup -c not quit after created bundle
2 participants