Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle shimming missing exports when preserving modules #4971

Merged
merged 1 commit into from May 3, 2023

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This ensures that modules with shimmed missing exports always get a chunk created when preserving modules

@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview May 3, 2023 6:18am

@github-actions
Copy link

github-actions bot commented May 3, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#missing-export-preserve-modules

or load it into the REPL:
https://rollup-flz5jri1z-rollup-js.vercel.app/repl/?pr=4971

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #4971 (3bcdf0c) into master (5628d16) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4971   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         222      222           
  Lines        8123     8123           
  Branches     2237     2237           
=======================================
  Hits         8041     8041           
  Misses         28       28           
  Partials       54       54           
Impacted Files Coverage Δ
src/Module.ts 100.00% <100.00%> (ø)

@lukastaegert lukastaegert merged commit 14e9d2d into master May 3, 2023
12 checks passed
@lukastaegert lukastaegert deleted the missing-export-preserve-modules branch May 3, 2023 17:17
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.21.4. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shimMissingExports will cause error when treeshake and preserveModules both is true
2 participants