Use correct scope in switch statements #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#switch-scopesor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4979 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 222 222
Lines 8128 8131 +3
Branches 2239 2239
=======================================
+ Hits 8046 8049 +3
Misses 28 28
Partials 54 54
|
|
This PR has been released as part of rollup@3.21.5. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Rollup wrongly used the inner "switch case" scope for the switch statement discriminant while it should have used the outer scope. This lead to wrong variable associations and invalid code, see the linked issue.