New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup shouldn't close stdout or subsequent writes will fail. #4995
Comments
Are you calling Rollup CLI as a Node script instead of as a separate process? How is it a problem that we close stdout but not that we call |
Yes, you can put it that way. The GitHub action does that. Using the firebase CLI alone doesn't produce the issue.
Good point! I'm not familiar with how processes are managed in node unfortunately. I created a repro to demonstrate the issue: https://github.com/mlstich/rollup-stdout-repro. |
Workaround (as an alternative to pinning the dependency): Redirect stdout to
|
Fix at #5004 |
This issue has been resolved via #5004 as part of rollup@3.22.1. You can test it via |
Awesome, thanks for the fix! |
Expected Behavior / Situation
The expected behaviour is the one before #4983 - not to close stdout with
process.stdout.end()
. Subsequent writes to stdout (through node) will continue to be successful.Actual Behavior / Situation
With #4983 / Rollup v3.21.6, stdout is closed. Subsequent writes to stdout will fail.
Our specific case:
Modification Proposal
Roll back the change in #4983 (and solve it differently, without affecting the node process beyond Rollup).
The text was updated successfully, but these errors were encountered: