Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup watches a path even if that id is loaded by load hook #5013

Closed
sapphi-red opened this issue May 26, 2023 · 7 comments
Closed

Rollup watches a path even if that id is loaded by load hook #5013

sapphi-red opened this issue May 26, 2023 · 7 comments

Comments

@sapphi-red
Copy link
Contributor

sapphi-red commented May 26, 2023

Rollup Version

3.22.0

Operating System (or Browser)

stackblitz

Node Version (if applicable)

No response

Link To Reproduction

https://stackblitz.com/edit/rollup-repro-zpgwkm?file=run.js

Expected Behaviour

If the content is loaded by a load hook (= the content isn't loaded by the rollup's default behavior), that path is not added to the watcher. If the content is loaded by a load hook, the content is not necessarily dependent on the file at that path.

Actual Behaviour

Even if the content is loaded by a load hook, that path is added to the watcher.

I'm not sure if this is an intended behavior. I'm wondering if this is a behavior to make it easier to create plugins.

related: vitejs/vite#13234

@lukastaegert
Copy link
Member

I think this is by accident. Following your arguments, though, I guess we should delay fixing it for the next major version as it might be a breaking change of sorts. I will make a note.

@github-actions
Copy link

This issue has been resolved via #5150 as part of rollup@4.0.0-21. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@4.0.0-21 or npm install rollup@beta. It will likely become part of a regular release later.

@github-actions
Copy link

This issue has been resolved via #5150 as part of rollup@4.0.0-22. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@4.0.0-22 or npm install rollup@beta. It will likely become part of a regular release later.

@github-actions
Copy link

This issue has been resolved via #5150 as part of rollup@4.0.0-23. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@4.0.0-23 or npm install rollup@beta. It will likely become part of a regular release later.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

This issue has been resolved via #5150 as part of rollup@4.0.0-24. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@4.0.0-24 or npm install rollup@beta. It will likely become part of a regular release later.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

This issue has been resolved via #5150 as part of rollup@4.0.0-25. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@4.0.0-25 or npm install rollup@beta. It will likely become part of a regular release later.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

This issue has been resolved via #5150 as part of rollup@4.0.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants