Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a trailing slash automatically for sourcemapBaseUrl #5022

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Jun 1, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5020

Description

@vercel
Copy link

vercel bot commented Jun 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2023 3:20pm

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #5022 (2f224c6) into master (b5ac3e5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5022   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files         222      222           
  Lines        8180     8183    +3     
  Branches     2253     2254    +1     
=======================================
+ Hits         8096     8099    +3     
  Misses         30       30           
  Partials       54       54           
Impacted Files Coverage Δ
src/utils/options/normalizeOutputOptions.ts 100.00% <100.00%> (ø)
src/utils/url.ts 100.00% <100.00%> (ø)

@TrickyPi TrickyPi changed the title fix: add a trailing slash automatically fix: add a trailing slash automatically for sourcemapBaseUrl Jun 1, 2023
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks great to me!

@lukastaegert lukastaegert added this pull request to the merge queue Jun 4, 2023
Merged via the queue into rollup:master with commit b221bde Jun 4, 2023
12 checks passed
@TrickyPi TrickyPi deleted the fix/trailing-slash branch June 4, 2023 07:04
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.23.1. You can test it via npm install rollup.

@rollup-bot rollup-bot mentioned this pull request Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sourcemapBaseUrl
3 participants