Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for linux riscv64 gnu #5288

Merged
merged 3 commits into from Dec 7, 2023
Merged

Add support for linux riscv64 gnu #5288

merged 3 commits into from Dec 7, 2023

Conversation

kxxt
Copy link
Contributor

@kxxt kxxt commented Dec 7, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Bump napi-rs/cli to 2.17, which is necessary for riscv64 support.

Add support for riscv64 linux gnu target.

I would very much appreciate it if a new release with riscv64 support could be published after we get this PR merged :)

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 8:37pm

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d77b682) 98.82% compared to head (ae54eb5) 98.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5288   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         232      232           
  Lines        8957     8957           
  Branches     2336     2336           
=======================================
  Hits         8852     8852           
  Misses         46       46           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert added this pull request to the merge queue Dec 7, 2023
Merged via the queue into rollup:master with commit 179b0ca Dec 7, 2023
28 checks passed
Copy link

github-actions bot commented Dec 8, 2023

This PR has been released as part of rollup@4.7.0. You can test it via npm install rollup.

kxxt added a commit to kxxt/darkreader that referenced this pull request Dec 8, 2023
rollup 4.7.0 added riscv64 support: rollup/rollup#5288

Updating rollup makes it possible to build darkreader on riscv64 linux.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants