Fully support arbitrary module namespace identifiers for all formats

[lukastaegert]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:

• resolves output.format: es deletes "quotes" from renamed exports #5286
• resolves export * as namespace does not support string literals #4784

Description

This should bring full support for arbitrary module namespace identifiers at last. While we already had partial support for some time, our parser now fully supports all variations since we switched to SWC. Unfortunately, we did not properly render these cases, though.
This PR seeks to fix all relevant scenarios:

• imported bindings from external dependencies that need to be quoted/escaped
• exported bindings that need to be quoted/escaped
• bindings in namespace objects that need to be quoted/escaped

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rollup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2023 5:29am

[github-actions]

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#arbitrary-namespace-identifiers

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-r16jp2hpv-rollup-js.vercel.app/repl/?pr=5298

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f9d85c) 98.82% compared to head (1381e95) 98.82%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5298   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         232      232           
  Lines        8962     8968    +6     
  Branches     2336     2338    +2     
=======================================
+ Hits         8857     8863    +6     
  Misses         46       46           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

This PR has been released as part of rollup@4.9.0. You can test it via npm install rollup.

[guybedford]

Great to see this fixed, thanks!