Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add estree.Program type to rollup.d.ts #5323

Merged
merged 5 commits into from Jan 4, 2024
Merged

Conversation

TrickyPi
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

resolves #5303

Description

Copy link

vercel bot commented Dec 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 7:26pm

Copy link

github-actions bot commented Dec 30, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#xiaopi-fix-5303

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-1w6qe3omf-rollup-js.vercel.app/repl/?pr=5323

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (347a347) 98.82% compared to head (c707f0a) 98.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5323   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         232      232           
  Lines        8973     8973           
  Branches     2338     2338           
=======================================
  Hits         8868     8868           
  Misses         46       46           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/rollup/types.d.ts Outdated Show resolved Hide resolved
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ProgramAst is a tautology as a Program IS the AST.
In the future, we may need names for other AST nodes,
so a naming scheme XXXNode should work well.
@lukastaegert lukastaegert added this pull request to the merge queue Jan 4, 2024
Merged via the queue into master with commit 8520c55 Jan 4, 2024
28 checks passed
@lukastaegert lukastaegert deleted the xiaopi-fix-5303 branch January 4, 2024 19:43
Copy link

github-actions bot commented Jan 5, 2024

This PR has been released as part of rollup@4.9.3. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ast type from getModuleInfo return value is not matched between docs and code
3 participants