New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add estree.Program type to rollup.d.ts #5323
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#xiaopi-fix-5303 Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5323 +/- ##
=======================================
Coverage 98.82% 98.82%
=======================================
Files 232 232
Lines 8973 8973
Branches 2338 2338
=======================================
Hits 8868 8868
Misses 46 46
Partials 59 59 ☔ View full report in Codecov by Sentry. |
1890d41
to
18157fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
ProgramAst is a tautology as a Program IS the AST. In the future, we may need names for other AST nodes, so a naming scheme XXXNode should work well.
This PR has been released as part of rollup@4.9.3. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #5303
Description