Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace glob.sync by globSync in code example #5376

Closed
4 tasks
adazmy opened this issue Feb 4, 2024 · 4 comments · Fixed by #5382
Closed
4 tasks

Replace glob.sync by globSync in code example #5376

adazmy opened this issue Feb 4, 2024 · 4 comments · Fixed by #5382

Comments

@adazmy
Copy link

adazmy commented Feb 4, 2024

Documentation is

  • Missing
  • Needed
  • Confusing
  • Not sure?

Please Explain in Detail...

On documentation section https://rollupjs.org/configuration-options/#input and in the provided configuration example, the glob.sync is no more supported by glob.

It's maybe the case in other sections too...

Your Proposal for Changes

Use globSync instead of glob.sync is broken since now it is globSync

@TrickyPi
Copy link
Member

TrickyPi commented Feb 5, 2024

Is there any document where I can find information indicating that glob.sync is no longer supported by glob?

@adazmy
Copy link
Author

adazmy commented Feb 5, 2024

isaacs/node-glob#493 (comment)

I was having the same error:

...
TypeError: glob.sync is not a function
...

@TrickyPi
Copy link
Member

TrickyPi commented Feb 6, 2024

It's weird. See https://stackblitz.com/edit/stackblitz-starters-7ggxfl?file=index.mjs. It works if using import { glob } from 'glob'; instead. Anyway, the docs section is wrong.

Copy link

This issue has been resolved via #5382 as part of rollup@4.10.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants