Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preserveSymlinks: 'auto' #5428

Closed
wants to merge 1 commit into from
Closed

Conversation

jun-sheaf
Copy link

@jun-sheaf jun-sheaf commented Mar 14, 2024

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Fixes #5427

Description

Implements auto-follow for symlinked modules.

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ❌ Failed (Inspect) Mar 14, 2024 5:41pm

@jun-sheaf
Copy link
Author

Not sure why Vercel is failing (I can't login with my GitHub account), but tests and docs are passing locally.

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.79%. Comparing base (1c8afed) to head (93feda1).
Report is 4 commits behind head on master.

Files Patch % Lines
src/utils/resolveId.ts 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5428      +/-   ##
==========================================
- Coverage   98.80%   98.79%   -0.01%     
==========================================
  Files         236      236              
  Lines        9423     9430       +7     
  Branches     2398     2402       +4     
==========================================
+ Hits         9310     9316       +6     
  Misses         48       48              
- Partials       65       66       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert
Copy link
Member

In order for this PR to be merged, we would also need to update @rollup/plugin-node-resolve. As the original author of this PR is now pursuing a different solution #5427 (comment), I will close this PR unless someone steps forward who wants to take over the topic.

@jun-sheaf
Copy link
Author

Closing this for now. I will keep the branch open for anyone who wants to take this over.

@jun-sheaf jun-sheaf closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preserveSymlinks: 'auto'
2 participants