Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deoptimize typeof for regular expression literals to better support es6-shim #2916

Merged
merged 1 commit into from Jun 10, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

As stated in the title, es6-shim scans if regular expressions have type function. This will deoptimize this check as I do not think this is a huge loss in treeshakeability.

@lukastaegert lukastaegert merged commit 1718faa into master Jun 10, 2019
@lukastaegert lukastaegert deleted the deopt-regexp-type branch June 10, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant