Prevent ASI errors for conditional expressions #3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3035 +/- ##
==========================================
+ Coverage 88.65% 88.68% +0.02%
==========================================
Files 165 165
Lines 5694 5708 +14
Branches 1738 1743 +5
==========================================
+ Hits 5048 5062 +14
Misses 388 388
Partials 258 258
Continue to review full report at Codecov.
|
|
Seems like coverage display is a little off, possibly due to me messing around with master lately. |
lukastaegert
changed the title
lukastaegert
force-pushed
the
prevent-asi-tree-shaking-issues
branch
from
0af6e0b
to
808d2da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3019
Description
This will remove linebreaks before simplified statements if this would lead to an erroneous automatic semicolon insertion. The logic is in place for both return and break statements and checks for simplifications in conditional, logical and sequence expressions.
The logic only removes line-breaks but does not touch other non-code characters to retain (annotation?) comments in the best possible way.