Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documents to use https, not http #3036

Merged
merged 1 commit into from Aug 7, 2019

Conversation

giraffate
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

Description

Fix documents to use https, not http.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #3036 into master will decrease coverage by 2.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3036     +/-   ##
=========================================
- Coverage   91.04%   88.65%   -2.4%     
=========================================
  Files         165      165             
  Lines        7708     5694   -2014     
  Branches     2704     1738    -966     
=========================================
- Hits         7018     5048   -1970     
+ Misses        471      388     -83     
- Partials      219      258     +39
Impacted Files Coverage Δ
src/ast/scopes/CatchScope.ts 20% <0%> (-22.86%) ⬇️
src/ast/nodes/BinaryExpression.ts 58.33% <0%> (-13.76%) ⬇️
src/ast/nodes/UnaryExpression.ts 75% <0%> (-13.47%) ⬇️
src/utils/path.ts 66.66% <0%> (-13.34%) ⬇️
src/finalisers/shared/getInteropBlock.ts 81.81% <0%> (-11.52%) ⬇️
src/ast/scopes/BlockScope.ts 60% <0%> (-11.43%) ⬇️
src/utils/renderChunk.ts 85% <0%> (-11.16%) ⬇️
src/finalisers/shared/setupNamespace.ts 90% <0%> (-10%) ⬇️
src/ast/nodes/ImportDeclaration.ts 80% <0%> (-7.5%) ⬇️
src/watch/index.ts 81.35% <0%> (-6.96%) ⬇️
... and 136 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1eef11...275fa50. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukastaegert lukastaegert merged commit bdac4aa into rollup:master Aug 7, 2019
@giraffate giraffate deleted the fix_documents_to_use_https branch August 7, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants