[v2.0.0] Remove experimentalOptimizeChunks #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-2.0.0 #3343 +/- ##
=================================================
+ Coverage 94.23% 95.00% +0.76%
=================================================
Files 173 172 -1
Lines 5949 5802 -147
Branches 1756 1712 -44
=================================================
- Hits 5606 5512 -94
+ Misses 190 157 -33
+ Partials 153 133 -20 Continue to review full report at Codecov.
|
|
i am for letting it stay and do your reimplamentation in a extra branch while keeping the original implamentation some do relay on it.you can do a none experimentalOtimizeChunks |
|
I can let it stay, but really, we cannot give any support for this. |
|
@lukastaegert i totally agree with your idea of manual chunks that only should get better documented i am for a deprecation msg added to expermentalOptimized as also a link to a valid replacement example in the documentation using manualChunks |
lukastaegert
force-pushed
the
remove-experimental-optimize-chunks
branch
from
2237c47
to
1952d2f
Compare
lukastaegert
force-pushed
the
release-2.0.0
branch
from
86f41ee
to
f4b9761
Compare
lukastaegert
force-pushed
the
remove-experimental-optimize-chunks
branch
2 times, most recently
from
db44224
to
f13c3b2
Compare
* Update CI to only run on Node 10 and 12, add engines to package.json * Update TypeScript target * Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests) * Remove minNodeVersion form tests * Reformat package.json
* Create a separate chunk for watch mode via a dynamic import * Bundle chokidar * Handle conditional fsevents import * Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify * Improve chunking * Refactor and simplify watcher * Make watcher a proper parameter * Only unwatch and watch on Linux systems * No longer run JS files through TypeScript for improved bundling performance
* Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage
lukastaegert
force-pushed
the
release-2.0.0
branch
from
771189e
to
cfdc86b
Compare
lukastaegert
force-pushed
the
remove-experimental-optimize-chunks
branch
from
f13c3b2
to
a969a6e
Compare
9 tasks
|
Id say drop this, there is a lot of work being done to optimize chunking already. |
lukastaegert
force-pushed
the
release-2.0.0
branch
from
d19c51a
to
467d666
Compare
|
I will remove the feature from the 2.0.0 branch for the time being. Effectively what this feature does is creating small manual chunks for very small shared modules, albeit in a fashion that avoids too much unnecessary code being loaded. It can be replicated via manual chunks, albeit with a little work. Once 2.0.0 is settled and the necessary refactorings are done, we can look if we want to reintroduce something like this. |
lukastaegert
force-pushed
the
release-2.0.0
branch
from
f950ad5
to
a5c193d
Compare
Thank you for your contribution! ❤️You can try out this pull request locally via or load it into the REPL: |
lukastaegert
added a commit
that referenced
this pull request
Feb 19, 2020
* [v2.0.0] Update minimum required Node version to 10 (#3346) * Update CI to only run on Node 10 and 12, add engines to package.json * Update TypeScript target * Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests) * Remove minNodeVersion form tests * Reformat package.json * [v2.0.0] Bundle chokidar (#3331) * Create a separate chunk for watch mode via a dynamic import * Bundle chokidar * Handle conditional fsevents import * Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify * Improve chunking * Refactor and simplify watcher * Make watcher a proper parameter * Only unwatch and watch on Linux systems * No longer run JS files through TypeScript for improved bundling performance * [v2.0.0] Remove active deprecations (#3352) * Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage * Remove experimentalOptimizeChunks * Remove more unused code
lukastaegert
added a commit
that referenced
this pull request
Feb 26, 2020
* [v2.0.0] Update minimum required Node version to 10 (#3346) * Update CI to only run on Node 10 and 12, add engines to package.json * Update TypeScript target * Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests) * Remove minNodeVersion form tests * Reformat package.json * [v2.0.0] Bundle chokidar (#3331) * Create a separate chunk for watch mode via a dynamic import * Bundle chokidar * Handle conditional fsevents import * Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify * Improve chunking * Refactor and simplify watcher * Make watcher a proper parameter * Only unwatch and watch on Linux systems * No longer run JS files through TypeScript for improved bundling performance * [v2.0.0] Remove active deprecations (#3352) * Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage * Remove experimentalOptimizeChunks * Remove more unused code
lukastaegert
added a commit
that referenced
this pull request
Mar 6, 2020
* [v2.0.0] Update minimum required Node version to 10 (#3346) * Update CI to only run on Node 10 and 12, add engines to package.json * Update TypeScript target * Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests) * Remove minNodeVersion form tests * Reformat package.json * [v2.0.0] Bundle chokidar (#3331) * Create a separate chunk for watch mode via a dynamic import * Bundle chokidar * Handle conditional fsevents import * Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify * Improve chunking * Refactor and simplify watcher * Make watcher a proper parameter * Only unwatch and watch on Linux systems * No longer run JS files through TypeScript for improved bundling performance * [v2.0.0] Remove active deprecations (#3352) * Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage * Remove experimentalOptimizeChunks * Remove more unused code
lukastaegert
added a commit
that referenced
this pull request
Mar 6, 2020
* [v2.0.0] Update minimum required Node version to 10 (#3346) * Update CI to only run on Node 10 and 12, add engines to package.json * Update TypeScript target * Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests) * Remove minNodeVersion form tests * Reformat package.json * [v2.0.0] Bundle chokidar (#3331) * Create a separate chunk for watch mode via a dynamic import * Bundle chokidar * Handle conditional fsevents import * Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify * Improve chunking * Refactor and simplify watcher * Make watcher a proper parameter * Only unwatch and watch on Linux systems * No longer run JS files through TypeScript for improved bundling performance * [v2.0.0] Remove active deprecations (#3352) * Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage * Remove experimentalOptimizeChunks * Remove more unused code
This was referenced Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Closes #3340
Description
experimentalOptimizeChunkshas for a long time been a badly tested, unmaintained huge chunk of code that added a lot of complexity. Now that actual issues started popping up for this feature, I would like to remove it for v2.0.0. If we want to reintroduce it later, I would write a completely new version based on moving the chunking to generateBundle first and not merging chunks after they have been created.