Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.0.0] Update minimum required Node version to 10 #3346

Merged
merged 5 commits into from Jan 20, 2020

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Jan 19, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3320

Description

  • Removes Node 6 and Node 8 from our CI setup
  • Adds an "engines" field to package.json
  • Switches to TypeScript target "es2018", which according to https://node.green/#ES2018 should be supported in Node 10 except for a minor incompatibility with Proxies
  • Remove "Bublé" transpilation from out test setup

@lukastaegert lukastaegert changed the title [v2.0.0] Update minimum node version to 10 [v2.0.0] Update minimum required Node version to 10 Jan 19, 2020
@lukastaegert lukastaegert added this to In progress in Release 2.0.0 via automation Jan 19, 2020
@lukastaegert lukastaegert moved this from In progress to Ready for merge in Release 2.0.0 Jan 19, 2020
@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

Merging #3346 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3346      +/-   ##
==========================================
- Coverage   93.22%   93.22%   -0.01%     
==========================================
  Files         172      172              
  Lines        6038     6037       -1     
  Branches     1800     1800              
==========================================
- Hits         5629     5628       -1     
  Misses        218      218              
  Partials      191      191
Impacted Files Coverage Δ
src/utils/defaultPlugin.ts 94% <ø> (ø) ⬆️
src/watch/chokidar.ts 75% <ø> (ø) ⬆️
src/ModuleLoader.ts 98.52% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56cbbdc...09d0814. Read the comment docs.

Copy link
Contributor

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like package.json was attacked by hard tabs.

package.json Outdated
"module": "dist/rollup.es.js",
"typings": "dist/rollup.d.ts",
"bin": {
"rollup": "./dist/bin/rollup"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attack of the tabs!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@lukastaegert lukastaegert changed the base branch from master to release-2.0.0 January 20, 2020 09:32
@lukastaegert lukastaegert merged commit 72f1ade into release-2.0.0 Jan 20, 2020
Release 2.0.0 automation moved this from Ready for merge to Done Jan 20, 2020
@lukastaegert lukastaegert deleted the update-minimum-node-version branch January 20, 2020 09:33
@lukastaegert lukastaegert mentioned this pull request Jan 20, 2020
9 tasks
lukastaegert added a commit that referenced this pull request Jan 21, 2020
* Update CI to only run on Node 10 and 12, add engines to package.json

* Update TypeScript target

* Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests)

* Remove minNodeVersion form tests

* Reformat package.json
lukastaegert added a commit that referenced this pull request Jan 28, 2020
* Update CI to only run on Node 10 and 12, add engines to package.json

* Update TypeScript target

* Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests)

* Remove minNodeVersion form tests

* Reformat package.json
lukastaegert added a commit that referenced this pull request Feb 4, 2020
* Update CI to only run on Node 10 and 12, add engines to package.json

* Update TypeScript target

* Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests)

* Remove minNodeVersion form tests

* Reformat package.json
lukastaegert added a commit that referenced this pull request Feb 8, 2020
* Update CI to only run on Node 10 and 12, add engines to package.json

* Update TypeScript target

* Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests)

* Remove minNodeVersion form tests

* Reformat package.json
lukastaegert added a commit that referenced this pull request Feb 14, 2020
* Update CI to only run on Node 10 and 12, add engines to package.json

* Update TypeScript target

* Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests)

* Remove minNodeVersion form tests

* Reformat package.json
lukastaegert added a commit that referenced this pull request Feb 14, 2020
* [v2.0.0] Update minimum required Node version to 10 (#3346)

* Update CI to only run on Node 10 and 12, add engines to package.json

* Update TypeScript target

* Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests)

* Remove minNodeVersion form tests

* Reformat package.json

* [v2.0.0] Bundle chokidar (#3331)

* Create a separate chunk for watch mode via a dynamic import

* Bundle chokidar

* Handle conditional fsevents import

* Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify

* Improve chunking

* Refactor and simplify watcher

* Make watcher a proper parameter

* Only unwatch and watch on Linux systems

* No longer run JS files through TypeScript for improved bundling performance

* [v2.0.0] Remove active deprecations (#3352)

* Remove active deprecations

* Make inactive deprecations active

* Improve coverage

* Improve coverage

* Refine transformer

* Improve coverage

* Refactoring option normalization

* Improve coverage

* Remove experimentalOptimizeChunks

* Remove more unused code
lukastaegert added a commit that referenced this pull request Feb 19, 2020
* Update CI to only run on Node 10 and 12, add engines to package.json

* Update TypeScript target

* Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests)

* Remove minNodeVersion form tests

* Reformat package.json
lukastaegert added a commit that referenced this pull request Feb 19, 2020
* [v2.0.0] Update minimum required Node version to 10 (#3346)

* Update CI to only run on Node 10 and 12, add engines to package.json

* Update TypeScript target

* Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests)

* Remove minNodeVersion form tests

* Reformat package.json

* [v2.0.0] Bundle chokidar (#3331)

* Create a separate chunk for watch mode via a dynamic import

* Bundle chokidar

* Handle conditional fsevents import

* Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify

* Improve chunking

* Refactor and simplify watcher

* Make watcher a proper parameter

* Only unwatch and watch on Linux systems

* No longer run JS files through TypeScript for improved bundling performance

* [v2.0.0] Remove active deprecations (#3352)

* Remove active deprecations

* Make inactive deprecations active

* Improve coverage

* Improve coverage

* Refine transformer

* Improve coverage

* Refactoring option normalization

* Improve coverage

* Remove experimentalOptimizeChunks

* Remove more unused code
lukastaegert added a commit that referenced this pull request Feb 26, 2020
* Update CI to only run on Node 10 and 12, add engines to package.json

* Update TypeScript target

* Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests)

* Remove minNodeVersion form tests

* Reformat package.json
lukastaegert added a commit that referenced this pull request Feb 26, 2020
* [v2.0.0] Update minimum required Node version to 10 (#3346)

* Update CI to only run on Node 10 and 12, add engines to package.json

* Update TypeScript target

* Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests)

* Remove minNodeVersion form tests

* Reformat package.json

* [v2.0.0] Bundle chokidar (#3331)

* Create a separate chunk for watch mode via a dynamic import

* Bundle chokidar

* Handle conditional fsevents import

* Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify

* Improve chunking

* Refactor and simplify watcher

* Make watcher a proper parameter

* Only unwatch and watch on Linux systems

* No longer run JS files through TypeScript for improved bundling performance

* [v2.0.0] Remove active deprecations (#3352)

* Remove active deprecations

* Make inactive deprecations active

* Improve coverage

* Improve coverage

* Refine transformer

* Improve coverage

* Refactoring option normalization

* Improve coverage

* Remove experimentalOptimizeChunks

* Remove more unused code
lukastaegert added a commit that referenced this pull request Mar 6, 2020
* Update CI to only run on Node 10 and 12, add engines to package.json

* Update TypeScript target

* Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests)

* Remove minNodeVersion form tests

* Reformat package.json
lukastaegert added a commit that referenced this pull request Mar 6, 2020
* [v2.0.0] Update minimum required Node version to 10 (#3346)

* Update CI to only run on Node 10 and 12, add engines to package.json

* Update TypeScript target

* Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests)

* Remove minNodeVersion form tests

* Reformat package.json

* [v2.0.0] Bundle chokidar (#3331)

* Create a separate chunk for watch mode via a dynamic import

* Bundle chokidar

* Handle conditional fsevents import

* Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify

* Improve chunking

* Refactor and simplify watcher

* Make watcher a proper parameter

* Only unwatch and watch on Linux systems

* No longer run JS files through TypeScript for improved bundling performance

* [v2.0.0] Remove active deprecations (#3352)

* Remove active deprecations

* Make inactive deprecations active

* Improve coverage

* Improve coverage

* Refine transformer

* Improve coverage

* Refactoring option normalization

* Improve coverage

* Remove experimentalOptimizeChunks

* Remove more unused code
lukastaegert added a commit that referenced this pull request Mar 6, 2020
* Update CI to only run on Node 10 and 12, add engines to package.json

* Update TypeScript target

* Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests)

* Remove minNodeVersion form tests

* Reformat package.json
lukastaegert added a commit that referenced this pull request Mar 6, 2020
* [v2.0.0] Update minimum required Node version to 10 (#3346)

* Update CI to only run on Node 10 and 12, add engines to package.json

* Update TypeScript target

* Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests)

* Remove minNodeVersion form tests

* Reformat package.json

* [v2.0.0] Bundle chokidar (#3331)

* Create a separate chunk for watch mode via a dynamic import

* Bundle chokidar

* Handle conditional fsevents import

* Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify

* Improve chunking

* Refactor and simplify watcher

* Make watcher a proper parameter

* Only unwatch and watch on Linux systems

* No longer run JS files through TypeScript for improved bundling performance

* [v2.0.0] Remove active deprecations (#3352)

* Remove active deprecations

* Make inactive deprecations active

* Improve coverage

* Improve coverage

* Refine transformer

* Improve coverage

* Refactoring option normalization

* Improve coverage

* Remove experimentalOptimizeChunks

* Remove more unused code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 2.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants