[v2.0.0] Remove active deprecations #3352

lukastaegert · 2020-01-21T19:46:23Z

This PR contains:

Are tests included?

yes (bugfixes and features will not be merged without tests)
no

Breaking Changes?

yes (breaking changes will not be merged unless absolutely necessary)
no

List any relevant issue numbers:

Description

The following plugin hooks that were already showing warnings in rollup@1 have been removed:
- ongenerate: use generateBundle instead
- onwrite: use writeBundle instead
- transformBundle: use renderChunk instead
- transformChunk: use renderChunk instead
You can no longer access this.watcher on the plugin context.
The transform hook can no longer return dependencies.
The treeshake.pureExternalModules option will now show a deprecation warning when used: use treeshake.moduleSideEffects: 'no-external' instead
Using import.meta.ROLLUP_ASSET_URL_<..> and import.meta.ROLLUP_CHUNK_URL_<..> in code will now show warnings: use import.meta.ROLLUP_FILE_URL_<..> instead
The resolveAssetUrl hook will now show a deprecation warning when used: use resolveFileUrl instead
The following plugin context functions will show warnings when used:
- this.emitAsset: use this.emitFile
- this.emitChunk: use this.emitFile
- this.getAssetFileName: use this.getFileName
- this.getChunkFileName: use this.getFileName
- this.isExternal: use this.resolve
- this.resolveId: use this.resolve
Directly adding properties to the bundle object in the generateBundle will show a warning (removing properties is allowed, though): Use this.emitFile
Accessing chunk.isAsset on the bundle is deprecated: Use chunk.type === 'asset' instead

This PR will also make sure that unknown output options will trigger a warning when using the JavaScript API.

codecov · 2020-01-21T19:51:23Z

Codecov Report

Merging #3352 into release-2.0.0 will increase coverage by 0.53%.
The diff coverage is 100%.

@@                Coverage Diff                @@
##           release-2.0.0    #3352      +/-   ##
=================================================
+ Coverage          93.53%   94.06%   +0.53%     
=================================================
  Files                173      174       +1     
  Lines               6049     5969      -80     
  Branches            1795     1764      -31     
=================================================
- Hits                5658     5615      -43     
+ Misses               211      191      -20     
+ Partials             180      163      -17

Impacted Files	Coverage Δ
src/utils/PluginContext.ts	`100% <ø> (ø)`	⬆️
cli/run/loadConfigFile.ts	`84% <ø> (ø)`	⬆️
src/utils/FileEmitter.ts	`100% <ø> (ø)`	⬆️
src/utils/timers.ts	`59.09% <ø> (ø)`	⬆️
src/utils/error.ts	`100% <ø> (ø)`	⬆️
src/utils/pluginUtils.ts	`100% <ø> (ø)`	⬆️
src/watch/watch-proxy.ts	`100% <ø> (ø)`	⬆️
src/ast/nodes/MetaProperty.ts	`100% <ø> (ø)`	⬆️
src/Chunk.ts	`93.98% <ø> (ø)`	⬆️
src/watch/watch.ts	`97.97% <100%> (ø)`	⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b9761...1e59438. Read the comment docs.

* Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage

* [v2.0.0] Update minimum required Node version to 10 (#3346) * Update CI to only run on Node 10 and 12, add engines to package.json * Update TypeScript target * Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests) * Remove minNodeVersion form tests * Reformat package.json * [v2.0.0] Bundle chokidar (#3331) * Create a separate chunk for watch mode via a dynamic import * Bundle chokidar * Handle conditional fsevents import * Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify * Improve chunking * Refactor and simplify watcher * Make watcher a proper parameter * Only unwatch and watch on Linux systems * No longer run JS files through TypeScript for improved bundling performance * [v2.0.0] Remove active deprecations (#3352) * Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage * Remove experimentalOptimizeChunks * Remove more unused code