Avoid invalid code when "else" branch is simplified #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t statement to avoid invalid code when the alternate branch is simplified.
Codecov Report
@@ Coverage Diff @@
## master #3421 +/- ##
==========================================
+ Coverage 93.29% 93.29% +<.01%
==========================================
Files 172 172
Lines 6112 6114 +2
Branches 1822 1823 +1
==========================================
+ Hits 5702 5704 +2
Misses 218 218
Partials 192 192
Continue to review full report at Codecov.
|
kzc
reviewed
Mar 5, 2020
src/ast/nodes/IfStatement.ts
Outdated
| @@ -82,6 +82,9 @@ export default class IfStatement extends StatementBase implements DeoptimizableE | |||
| } | |||
| if (this.alternate !== null) { | |||
| if (this.alternate.included) { | |||
| if (code.original.charCodeAt(this.alternate.start - 1) === 101 /* f */) { | |||
There was a problem hiding this comment.
I'm always up for a good puzzle... What's the significance of f? Or is it e?
$ node -p 'String.fromCharCode(101)'
e
$ node -p 'String.fromCharCode(102)'
f
There was a problem hiding this comment.
The beauty of comments. I definitely did NOT copy this code from for..of loop 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3419
Description
This ensures that in a situation such as #3419, there is always whitespace or a similar separator between the "else" keyword and the following branch so that the expression can be transformed freely. This is a similar fix as was previously implemented for for..in and for..of statements.