Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update magic-string to fix sourcemaps #3423

Merged
merged 1 commit into from Mar 6, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This updates the magic-string dependency to fix incorrect sourcemaps when tree-shaking occurs in a multi-file bundle.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#2.0.0-fix-sourcemaps

or load it into the REPL:
https://rollupjs.org/repl/?circleci=9764

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #3423 into release-2.0.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-2.0.0   #3423   +/-   ##
=============================================
  Coverage             95%     95%           
=============================================
  Files                171     171           
  Lines               5831    5831           
  Branches            1722    1722           
=============================================
  Hits                5540    5540           
  Misses               157     157           
  Partials             134     134

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7523f0...a277606. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants