Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strict types with PluginDriver #3426

Merged
merged 3 commits into from Mar 10, 2020
Merged

Use strict types with PluginDriver #3426

merged 3 commits into from Mar 10, 2020

Conversation

NotWoods
Copy link
Member

@NotWoods NotWoods commented Mar 6, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Adds strict typing for the PluginDriver class.

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #3426 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3426   +/-   ##
=======================================
  Coverage   95.00%   95.01%           
=======================================
  Files         171      171           
  Lines        5831     5834    +3     
  Branches     1722     1722           
=======================================
+ Hits         5540     5543    +3     
  Misses        157      157           
  Partials      134      134           
Impacted Files Coverage Δ
src/utils/renderChunk.ts 100.00% <ø> (ø)
src/utils/transform.ts 98.43% <ø> (ø)
src/ast/nodes/MetaProperty.ts 100.00% <100.00%> (ø)
src/rollup/rollup.ts 100.00% <100.00%> (ø)
src/utils/PluginDriver.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc267e...1ac2845. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! There were small remaining type errors in the code which were picked up by CI. You can also run this check manually via npm run test:typescript. Luckily, they were easy to fix so I took the liberty of pushing the fix to your branch.

@lukastaegert lukastaegert merged commit 77dbe1f into rollup:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants