Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditional exports again for ESM #3430

Merged
merged 2 commits into from Mar 7, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

The previous fix apparently broke the ESM import due to an ordering issue, so here we go again...

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-conditional-exports-again

or load it into the REPL:
https://rollupjs.org/repl/?circleci=9816

@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #3430 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3430   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files         171      171           
  Lines        5831     5831           
  Branches     1722     1722           
=======================================
  Hits         5540     5540           
  Misses        157      157           
  Partials      134      134           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 676bb03...013e5e0. Read the comment docs.

@lukastaegert lukastaegert merged commit b5b9164 into master Mar 7, 2020
@lukastaegert lukastaegert deleted the fix-conditional-exports-again branch March 7, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants