Make sure logical expressions always check the left argument for side effects #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #3438 +/- ##
==========================================
+ Coverage 95.01% 95.01% +<.01%
==========================================
Files 171 171
Lines 5838 5840 +2
Branches 1723 1723
==========================================
+ Hits 5547 5549 +2
Misses 157 157
Partials 134 134
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3382
Description
There is a bug in logical expressions in that it would only check one of the arguments for side-effects if the value can be resolved at some point. However, checking for side-effects has the "side-effect" of binding new assignments, which in the linked issue was necessary to trigger some deoptimizations. The fix here is rather small even though tracking it was quite intricate.