Add optional importer parameter to this.emitFile
#3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukastaegert
force-pushed
the
add-importer-emitfile
branch
from
5e15861
to
6df327f
Compare
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #3442 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 171 171
Lines 5841 5843 +2
Branches 1723 1724 +1
=======================================
+ Hits 5550 5552 +2
Misses 157 157
Partials 134 134
Continue to review full report at Codecov.
|
|
I haven't tested it, but at a glance this is exactly what I was asking for! |
Co-Authored-By: Jake Archibald <jaffathecake@gmail.com>
sthagen
added a commit
to sthagen/rollup-rollup
that referenced
this pull request
Mar 18, 2020
Add optional `importer` parameter to `this.emitFile` (rollup#3442)
|
Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3436
Description
This adds the possibility to specify an importing file when using
this.emitFileso that relative ids can be resolved correctly. Also cleans up documentation and types to specify thatimportercan actually beundefined, in which case the current working directory is used as reference.