Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Use esm Output Format (Alias) #3468

Merged
merged 1 commit into from Mar 29, 2020
Merged

Don't Use esm Output Format (Alias) #3468

merged 1 commit into from Mar 29, 2020

Conversation

vsn4ik
Copy link
Contributor

@vsn4ik vsn4ik commented Mar 28, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Part of the edits expected in #3381

@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #3468 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3468   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files         171      171           
  Lines        5861     5861           
  Branches     1732     1732           
=======================================
  Hits         5573     5573           
  Misses        156      156           
  Partials      132      132           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dade1fc...b3db51d. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@lukastaegert lukastaegert merged commit 618e7f6 into rollup:master Mar 29, 2020
@vsn4ik vsn4ik deleted the output-format-es branch March 29, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants