feat: Call namespace error as a warning #3475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Again I have no idea why there are these trailing commas added or how to change that in the git hooks. |
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #3475 +/- ##
==========================================
+ Coverage 95.81% 95.84% +0.03%
==========================================
Files 174 174
Lines 5898 5898
Branches 1736 1736
==========================================
+ Hits 5651 5653 +2
+ Misses 127 126 -1
+ Partials 120 119 -1
Continue to review full report at Codecov.
|
It's the new default of prettier@2. I will add a setting to change that. |
lukastaegert
force-pushed
the
call-ns-warn
branch
from
b28e871
to
0a46cd3
Compare
lukastaegert
force-pushed
the
call-ns-warn
branch
from
0a46cd3
to
acf0777
Compare
lukastaegert
approved these changes
Mar 31, 2020
|
Thanks for the quick review! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the error when a namespace is called into a warning.
The reason being that there may exist valid runtime paths through the code that do not trigger the error, despite it being invalid. So allowing the build to proceed can allow valid runtime code to work despite the underlying "typing issue".
Alternatively it might be worth considering a strict / loose mode for Rollup "typing errors" so far as it cares about module semantics, but I actually think it would be better to treat Rollup as allowing anything to execute which would execute in a JS engine, since it is not a type system.
Landing as-is seems sensible to me, but I would be open to suggestions too.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description