Always create a dynamic namespace object when a module with synthetic named exports is imported dynamically #3648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves rollup/plugins#467
Description
Unfortunately until now, dynamically importing a module with synthetic named exports only returned a "regular" namespace that did not contain properties of the default export. This PR fixes this by always forcing the creation of a proper namespace object in these situations that contains both the named exports and the properties of the default export and returning this when a dynamic import is used.