Do not treat string.replace as side effect when used with a literal #4494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#string-replace-side-effectsor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4494 +/- ##
==========================================
- Coverage 98.74% 98.74% -0.01%
==========================================
Files 207 207
Lines 7343 7342 -1
Branches 2082 2081 -1
==========================================
- Hits 7251 7250 -1
Misses 33 33
Partials 59 59
Continue to review full report at Codecov.
|
lukastaegert
force-pushed
the
string-replace-side-effects
branch
from
f5aa8ff
to
c1ff8b3
Compare
|
Confirmed to be working locally with With regards to mrdoob/three.js#24006 it didn't make too much of a difference as many of those declarations are still being used, but in my tests it does remove a little bit more unused code. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This improves side effect detection for
String.prototype.replaceandString.prototype.replaceAllby not treating them as side effects when used with literals as second argument.