Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set permissions for GitHub actions #4528

Merged
merged 2 commits into from Jun 20, 2022

Conversation

naveensrinivasan
Copy link
Contributor

 Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)

Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@lukastaegert lukastaegert enabled auto-merge (squash) June 20, 2022 07:12
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #4528 (4deb5da) into master (288bf77) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4528   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files         208      208           
  Lines        7332     7332           
  Branches     2094     2094           
=======================================
  Hits         7251     7251           
  Misses         26       26           
  Partials       55       55           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 288bf77...4deb5da. Read the comment docs.

@lukastaegert lukastaegert merged commit c1fcbbd into rollup:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants