New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3.0] Custom awaiting watch emitter #4609
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#customer-watch-emitter or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## release-3.0.0 #4609 +/- ##
==============================================
Coverage 98.97% 98.97%
==============================================
Files 211 211
Lines 7428 7445 +17
Branches 2101 2104 +3
==============================================
+ Hits 7352 7369 +17
Misses 23 23
Partials 53 53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* Use a custom watch emitter implementation * Add documentation * Improve coverage
This PR has been released as part of rollup@3.0.0-5. Note that this is a pre-release, so to test it, you need to install Rollup via |
* Use a custom watch emitter implementation * Add documentation * Improve coverage
This PR has been released as part of rollup@3.0.0-6. Note that this is a pre-release, so to test it, you need to install Rollup via |
* Use a custom watch emitter implementation * Add documentation * Improve coverage
This PR has been released as part of rollup@3.0.0-7. Note that this is a pre-release, so to test it, you need to install Rollup via |
This PR has been released as part of rollup@3.0.0-8. Note that this is a pre-release, so to test it, you need to install Rollup via |
* Use a custom watch emitter implementation * Add documentation * Improve coverage
This PR has been released as part of rollup@3.0.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This replaces the watch emitter, that used to be based on a NodeJS event emitter, with a custom implementation that allows the user to return a Promise from any listener to make Rollup wait at that stage before continuing.