Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.0] Custom awaiting watch emitter #4609

Merged
merged 3 commits into from Aug 30, 2022

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This replaces the watch emitter, that used to be based on a NodeJS event emitter, with a custom implementation that allows the user to return a Promise from any listener to make Rollup wait at that stage before continuing.

@lukastaegert lukastaegert changed the title [v3.0] Custom watch emitter [v3.0] Custom awaiting watch emitter Aug 17, 2022
@github-actions
Copy link

github-actions bot commented Aug 17, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#customer-watch-emitter

or load it into the REPL:
https://rollupjs.org/repl/?pr=4609

@lukastaegert lukastaegert added this to In progress in Release 3.0.0 via automation Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #4609 (c5c6b66) into release-3.0.0 (eac06ac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           release-3.0.0    #4609   +/-   ##
==============================================
  Coverage          98.97%   98.97%           
==============================================
  Files                211      211           
  Lines               7428     7445   +17     
  Branches            2101     2104    +3     
==============================================
+ Hits                7352     7369   +17     
  Misses                23       23           
  Partials              53       53           
Impacted Files Coverage Δ
src/Graph.ts 100.00% <100.00%> (ø)
src/watch/WatchEmitter.ts 100.00% <100.00%> (ø)
src/watch/watch.ts 99.12% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert moved this from In progress to Ready for merge in Release 3.0.0 Aug 17, 2022
@lukastaegert lukastaegert merged commit 4c4c4ba into release-3.0.0 Aug 30, 2022
@lukastaegert lukastaegert deleted the customer-watch-emitter branch August 30, 2022 12:06
Release 3.0.0 automation moved this from Ready for merge to Done Aug 30, 2022
@lukastaegert lukastaegert mentioned this pull request Aug 30, 2022
9 tasks
lukastaegert added a commit that referenced this pull request Aug 31, 2022
* Use a custom watch emitter implementation

* Add documentation

* Improve coverage
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.0.0-5. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@3.0.0-5 or npm install rollup@beta. It will likely become part of a regular release later.

lukastaegert added a commit that referenced this pull request Sep 6, 2022
* Use a custom watch emitter implementation

* Add documentation

* Improve coverage
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.0.0-6. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@3.0.0-6 or npm install rollup@beta. It will likely become part of a regular release later.

lukastaegert added a commit that referenced this pull request Sep 22, 2022
* Use a custom watch emitter implementation

* Add documentation

* Improve coverage
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.0.0-7. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@3.0.0-7 or npm install rollup@beta. It will likely become part of a regular release later.

@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.0.0-8. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@3.0.0-8 or npm install rollup@beta. It will likely become part of a regular release later.

lukastaegert added a commit that referenced this pull request Oct 11, 2022
* Use a custom watch emitter implementation

* Add documentation

* Improve coverage
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.0.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 3.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants