New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3.0] Remove implicit default export mode warning #4624
[v3.0] Remove implicit default export mode warning #4624
Conversation
d27724e
to
b796c55
Compare
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#remove-implicit-default-mode-warning or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## release-3.0.0 #4624 +/- ##
================================================
Coverage ? 98.96%
================================================
Files ? 211
Lines ? 7474
Branches ? 2110
================================================
Hits ? 7397
Misses ? 23
Partials ? 54 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This PR has been released as part of rollup@3.0.0-5. Note that this is a pre-release, so to test it, you need to install Rollup via |
This PR has been released as part of rollup@3.0.0-6. Note that this is a pre-release, so to test it, you need to install Rollup via |
3.0.0-5 Improve issue comment RegExp
3.0.0-5 Improve issue comment RegExp
This PR has been released as part of rollup@3.0.0-7. Note that this is a pre-release, so to test it, you need to install Rollup via |
This PR has been released as part of rollup@3.0.0-8. Note that this is a pre-release, so to test it, you need to install Rollup via |
3.0.0-5 Improve issue comment RegExp
This PR has been released as part of rollup@3.0.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Originally I wanted to include this change in the interop overhaul #4611 but forgot about it. There currently is a warning when using
auto
export mode and having only a default export that this may cause problems for tools that resolve arequire
expression with an ES module. While this case is still relevant, this is really no problem for NodeJS interop where instead switching to named export mode would cause greater issues.