Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.0] Remove implicit default export mode warning #4624

Merged
merged 1 commit into from Aug 30, 2022

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Originally I wanted to include this change in the interop overhaul #4611 but forgot about it. There currently is a warning when using auto export mode and having only a default export that this may cause problems for tools that resolve a require expression with an ES module. While this case is still relevant, this is really no problem for NodeJS interop where instead switching to named export mode would cause greater issues.

@lukastaegert lukastaegert changed the base branch from master to release-3.0.0 August 30, 2022 18:20
@lukastaegert lukastaegert force-pushed the remove-implicit-default-mode-warning branch from d27724e to b796c55 Compare August 30, 2022 18:20
@github-actions
Copy link

github-actions bot commented Aug 30, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#remove-implicit-default-mode-warning

or load it into the REPL:
https://rollupjs.org/repl/?pr=4624

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-3.0.0@e0bdf9c). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-3.0.0    #4624   +/-   ##
================================================
  Coverage                 ?   98.96%           
================================================
  Files                    ?      211           
  Lines                    ?     7474           
  Branches                 ?     2110           
================================================
  Hits                     ?     7397           
  Misses                   ?       23           
  Partials                 ?       54           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit 71c12c3 into release-3.0.0 Aug 30, 2022
@lukastaegert lukastaegert deleted the remove-implicit-default-mode-warning branch August 30, 2022 18:43
@lukastaegert lukastaegert added this to In progress in Release 3.0.0 via automation Aug 31, 2022
@lukastaegert lukastaegert mentioned this pull request Aug 31, 2022
9 tasks
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.0.0-5. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@3.0.0-5 or npm install rollup@beta. It will likely become part of a regular release later.

@lukastaegert lukastaegert moved this from In progress to Done in Release 3.0.0 Aug 31, 2022
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.0.0-6. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@3.0.0-6 or npm install rollup@beta. It will likely become part of a regular release later.

lukastaegert added a commit that referenced this pull request Sep 6, 2022
lukastaegert added a commit that referenced this pull request Sep 22, 2022
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.0.0-7. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@3.0.0-7 or npm install rollup@beta. It will likely become part of a regular release later.

@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.0.0-8. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@3.0.0-8 or npm install rollup@beta. It will likely become part of a regular release later.

lukastaegert added a commit that referenced this pull request Oct 11, 2022
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.0.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 3.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants