Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.0] Change default for systemNullSetters #4649

Merged
merged 1 commit into from Oct 7, 2022

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

One last change I stumbled upon when looking through the options. The systemNullSetters was introduced to generate slightly simplified output for SystemJS >= 6.3.3. I reckon it makes sense to enable it by default now.

@lukastaegert lukastaegert changed the base branch from master to release-3.0.0 October 5, 2022 04:24
@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#rollup-3-system-null-setters

or load it into the REPL:
https://rollupjs.org/repl/?pr=4649

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #4649 (2389d5f) into release-3.0.0 (5812006) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           release-3.0.0    #4649   +/-   ##
==============================================
  Coverage          98.97%   98.97%           
==============================================
  Files                213      213           
  Lines               7481     7481           
  Branches            2112     2112           
==============================================
  Hits                7404     7404           
  Misses                23       23           
  Partials              54       54           
Impacted Files Coverage Δ
src/utils/options/normalizeOutputOptions.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit b33513c into release-3.0.0 Oct 7, 2022
@lukastaegert lukastaegert deleted the rollup-3-system-null-setters branch October 7, 2022 17:36
@lukastaegert lukastaegert mentioned this pull request Oct 11, 2022
9 tasks
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.0.0-8. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@3.0.0-8 or npm install rollup@beta. It will likely become part of a regular release later.

@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.0.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants