Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shebang does not support window causes run script error #4662

Merged
merged 1 commit into from Oct 12, 2022
Merged

fix: shebang does not support window causes run script error #4662

merged 1 commit into from Oct 12, 2022

Conversation

c0dedance
Copy link
Contributor

@c0dedance c0dedance commented Oct 12, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

fix: shebang does not support window , missing "node" causes run script error
image
image

@c0dedance c0dedance changed the title fix: missing "node" causes run script error fix: Shebang does not support window causes run script error Oct 12, 2022
@c0dedance c0dedance changed the title fix: Shebang does not support window causes run script error fix: shebang does not support window causes run script error Oct 12, 2022
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks a lot!

@lukastaegert lukastaegert enabled auto-merge (squash) October 12, 2022 03:57
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #4662 (2c05aea) into master (5c74cd9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4662   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files         214      214           
  Lines        7554     7554           
  Branches     2096     2096           
=======================================
  Hits         7483     7483           
  Misses         23       23           
  Partials       48       48           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit 8a2949e into rollup:master Oct 12, 2022
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.0.1. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants