Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve & simplify types #4675

Merged
merged 3 commits into from Oct 16, 2022
Merged

refactor: improve & simplify types #4675

merged 3 commits into from Oct 16, 2022

Conversation

sxzz
Copy link
Contributor

@sxzz sxzz commented Oct 15, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Improve & simplify types.

@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #4675 (df883f0) into master (11d425b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4675      +/-   ##
==========================================
- Coverage   99.02%   99.02%   -0.01%     
==========================================
  Files         215      215              
  Lines        7552     7551       -1     
  Branches     2092     2091       -1     
==========================================
- Hits         7478     7477       -1     
  Misses         24       24              
  Partials       50       50              
Impacted Files Coverage Δ
src/Chunk.ts 100.00% <100.00%> (ø)
src/Graph.ts 100.00% <100.00%> (ø)
src/ModuleLoader.ts 100.00% <100.00%> (ø)
src/utils/options/mergeOptions.ts 100.00% <100.00%> (ø)
src/utils/options/normalizeInputOptions.ts 100.00% <100.00%> (ø)
src/utils/options/normalizeOutputOptions.ts 100.00% <100.00%> (ø)
src/utils/renderChunks.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice changes, thank you! Just one minor comment.

src/Chunk.ts Show resolved Hide resolved
src/ModuleLoader.ts Show resolved Hide resolved
src/rollup/types.d.ts Outdated Show resolved Hide resolved
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, great work!

@lukastaegert lukastaegert merged commit 21a4bdf into rollup:master Oct 16, 2022
@sxzz sxzz deleted the improve/types branch October 16, 2022 19:15
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.2.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants