Support emitting files via manualChunks in output #4761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4746-emit-via-manual-chunkor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4761 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 217 217
Lines 7749 7762 +13
Branches 2147 2148 +1
=======================================
+ Hits 7674 7687 +13
Misses 24 24
Partials 51 51
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This PR has been released as part of rollup@3.8.0. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This changes the logic for emitting files to handle files emitted during output generation phase via a transform hooks that is triggered for the first time by the
manualChunksoption of that output. This may not be exactly what users expect, but it is difficult to differentiate legitimate uses of the file emitter from illegitimate uses, especially with new features in the pipeline.As a follow-up, it would be worthwhile to add a way for assets to obey tree-shaking in so far that assets that are never referenced are not emitted.