Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more restrictive types #4782

Merged
merged 5 commits into from Jan 2, 2023
Merged

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Dec 31, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@codecov
Copy link

codecov bot commented Dec 31, 2022

Codecov Report

Merging #4782 (1f05bf1) into master (023ed0f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4782      +/-   ##
==========================================
- Coverage   99.03%   99.03%   -0.01%     
==========================================
  Files         217      217              
  Lines        7774     7773       -1     
  Branches     2159     2158       -1     
==========================================
- Hits         7699     7698       -1     
  Misses         24       24              
  Partials       51       51              
Impacted Files Coverage Δ
src/Bundle.ts 100.00% <ø> (ø)
src/ast/scopes/ClassBodyScope.ts 100.00% <ø> (ø)
src/ast/scopes/ModuleScope.ts 100.00% <ø> (ø)
src/ast/scopes/ParameterScope.ts 100.00% <ø> (ø)
src/ast/variables/ExportShimVariable.ts 100.00% <ø> (ø)
src/ast/variables/ExternalVariable.ts 100.00% <ø> (ø)
src/ast/variables/NamespaceVariable.ts 100.00% <ø> (ø)
src/ast/variables/SyntheticNamedExportVariable.ts 100.00% <ø> (ø)
src/finalisers/cjs.ts 100.00% <ø> (ø)
src/finalisers/es.ts 100.00% <ø> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert enabled auto-merge (squash) January 2, 2023 09:37
@lukastaegert lukastaegert merged commit c6c8844 into rollup:master Jan 2, 2023
@dnalborczyk dnalborczyk deleted the restrictive-types branch January 2, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants