Improve and fix cross-chunk-reexport warning #4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rollupjs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#cross-chunk-reexportsor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4829 +/- ##
==========================================
- Coverage 99.00% 98.99% -0.02%
==========================================
Files 219 219
Lines 7834 7837 +3
Branches 2168 2170 +2
==========================================
+ Hits 7756 7758 +2
Misses 26 26
- Partials 52 53 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
9 tasks
lukastaegert
force-pushed
the
cross-chunk-reexports
branch
from
c1fdf07
to
e440b4d
Compare
|
This PR has been released as part of rollup@3.12.1. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
The root cause of #4804 was that namespace exports do not have an export name. This fixes the warning by using "*" as the export name. It also shows the warning in more situations as it was omitted if one export was a namespace and we were preserving modules.