Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle manual chunks where the entry is not part of the module graph #4921

Merged
merged 1 commit into from Mar 24, 2023

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Mar 23, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

In the course of #4723, I accidentally removed a conditional that was important to handle manual chunks where the entry point is not part of the module graph. This is fixed here and now properly tested.

@github-actions
Copy link

github-actions bot commented Mar 23, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4908-manual-chunk-non-included-entry

or load it into the REPL:
https://deploy-preview-4921--rollupjs.netlify.app/repl/?pr=4921

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #4921 (6be3554) into master (66eda90) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4921   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         221      221           
  Lines        8049     8051    +2     
  Branches     2214     2215    +1     
=======================================
+ Hits         7970     7972    +2     
  Misses         26       26           
  Partials       53       53           
Impacted Files Coverage Δ
src/ast/nodes/Program.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit b6c4fd8 into master Mar 24, 2023
14 checks passed
@lukastaegert lukastaegert deleted the gh-4908-manual-chunk-non-included-entry branch March 24, 2023 06:01
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.20.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'type') error happens when manualChunks is used
2 participants