From 4a9491f7086d1845b14b1bc915df9b06259ee4f8 Mon Sep 17 00:00:00 2001 From: Travis Nielsen Date: Wed, 10 Nov 2021 09:13:03 -0700 Subject: [PATCH] rgw: raise errors when rgw daemon fails to be created The generation of the rgw deployment spec was swallowing errors if any issues are raised such as the tls cert not being found as expected in some configurations. We need to fail the reconcile so the error will be logged and the admin can identify the issue. Signed-off-by: Travis Nielsen (cherry picked from commit 9ecd0cbc7563705ca7de34c65370cca9dcd91a9e) --- pkg/operator/ceph/object/rgw.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/operator/ceph/object/rgw.go b/pkg/operator/ceph/object/rgw.go index f51251406096..6741825681fc 100644 --- a/pkg/operator/ceph/object/rgw.go +++ b/pkg/operator/ceph/object/rgw.go @@ -142,7 +142,7 @@ func (c *clusterConfig) startRGWPods(realmName, zoneGroupName, zoneName string) // Create deployment deployment, err := c.createDeployment(rgwConfig) if err != nil { - return nil + return errors.Wrap(err, "failed to create rgw deployment") } logger.Infof("object store %q deployment %q created", c.store.Name, deployment.Name)