From e5cca4118e13738336927199882e3aa122d0ca0d Mon Sep 17 00:00:00 2001 From: Blaine Gardner Date: Thu, 4 Nov 2021 14:40:37 -0600 Subject: [PATCH] Revert "ci: trigger push build action after tag creation" This reverts commit c53304c3b4f762488d8129cecc65282eaa612acc. After experimenting with this release, we have found that the `workflow_run` action source doesn't work for branches. The documentation was updated with this PR and has more detail. https://github.com/github/docs/pull/531 For now, we will revert back to using on.push.tags = ["v*"] Signed-off-by: Blaine Gardner (cherry picked from commit 30e02c1063a2c9568edb651563e4f6b5efeb0225) --- .github/workflows/push-build.yaml | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/.github/workflows/push-build.yaml b/.github/workflows/push-build.yaml index b1a585d8e217..089eaec3707b 100644 --- a/.github/workflows/push-build.yaml +++ b/.github/workflows/push-build.yaml @@ -4,9 +4,8 @@ on: branches: - master - release-* - workflow_run: - workflows: ["Tag"] - types: [completed] + tags: + - v* defaults: run: @@ -16,12 +15,7 @@ defaults: jobs: push-image-to-container-registry: runs-on: ubuntu-18.04 - # github.repository == 'rook/rook': for running the test only in 'rook/rook' repo - # github.event_name == 'push': This is for any push to master or release branches - # github.event.workflow_run.conclusion == 'success': For the tagged workflow completion - if: | - github.repository == 'rook/rook' && - (github.event_name == 'push' || github.event.workflow_run.conclusion == 'success') + if: github.repository == 'rook/rook' steps: - name: checkout uses: actions/checkout@v2