Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: fix lvm osd db device check #8267

Merged
merged 1 commit into from Sep 13, 2021
Merged

ceph: fix lvm osd db device check #8267

merged 1 commit into from Sep 13, 2021

Conversation

lyind
Copy link
Contributor

@lyind lyind commented Jul 5, 2021

Description of your changes:
Apparently ceph-volume reports back LVs specified as /dev/vg/lv as vg/lv. Tollerate vg/lv format when checking for correct db device after ceph-volume execution.

Which issue is resolved by this Pull Request:
Resolves #8266

@lyind lyind changed the title volume: fix lvm osd db device check ceph: fix lvm osd db device check Jul 5, 2021
@mergify mergify bot added the ceph main ceph tag label Jul 5, 2021
@lyind
Copy link
Contributor Author

lyind commented Jul 5, 2021

When testing this situation / fix in this PR with Ceph v16.2.4, maybe also have a look at: ceph/ceph#42181

Without that change in Ceph, I wasn't able to actually pass the ceph-volume step.

@subhamkrai
Copy link
Contributor

@lyind Thanks for the PR, please sign off your commit.

@lyind
Copy link
Contributor Author

lyind commented Jul 6, 2021

@lyind Thanks for the PR, please sign off your commit.

Done (force-pushed).

pkg/daemon/ceph/osd/volume.go Show resolved Hide resolved
@leseb
Copy link
Member

leseb commented Jul 19, 2021

@sp98 PTAL

@leseb
Copy link
Member

leseb commented Sep 9, 2021

@lyind sorry for keeping you waiting, could rebase your branch with the current head of the master branch? Then we should be good to go. Thanks

Signed-off-by: Jonas Zeiger <jonas.zeiger@talpidae.net>
@lyind
Copy link
Contributor Author

lyind commented Sep 13, 2021

@leseb Rebase done. Thanks for picking this up.

@travisn travisn merged commit 99811e5 into rook:master Sep 13, 2021
travisn added a commit that referenced this pull request Sep 13, 2021
ceph: fix lvm osd db device check (backport #8267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ceph main ceph tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rook volume.go initializeDevicesLVMMode() incompatible with ceph-volume
5 participants