Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rook resources should be created with the kubernetes recommended labels #8400

Closed
TomHellier opened this issue Jul 27, 2021 · 1 comment · Fixed by #8678
Closed

Rook resources should be created with the kubernetes recommended labels #8400

TomHellier opened this issue Jul 27, 2021 · 1 comment · Fixed by #8678
Assignees
@parth-gr
Labels
feature
Projects
v1.8

Comments

@TomHellier
Copy link
Contributor

  • Feature Request

What should the feature do:
Kubernetes recommends applying the following recommended labels to resources deployed in a kubernetes cluster.

for example:

    app.kubernetes.io/name: rook-ceph
    app.kubernetes.io/instance: rook-ceph
    app.kubernetes.io/version: "v1.6.8"
    app.kubernetes.io/component: csi
    app.kubernetes.io/part-of: rook-ceph
    app.kubernetes.io/managed-by: rook-ceph-operator
    app.kubernetes.io/created-by: rook-ceph-operator

see this kubernetes/ingress-nginx#5185 for an example of how to apply it to a helm chart, but I think the resources created by the rook-ceph operator should also use the recommended labels.

What is use case behind this feature:
This allows you to support tooling which makes use of the recommended labels, the recommended labels describe applications in a way that can be queried, for example a kubectl can run on all csi resources in the rook-ceph namespace.
@leseb leseb added this to To do in v1.7 via automation Jul 27, 2021
@leseb leseb added the beginner label Jul 29, 2021
@leseb leseb mentioned this issue Aug 6, 2021
Merged
10 tasks
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 9, 2021
@parth-gr
build: create resources with k8s recommended labels
2aa72fb 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
@parth-gr parth-gr mentioned this issue Sep 9, 2021
Merged
10 tasks
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 9, 2021
@parth-gr
build: create resources with k8s recommended labels
e9705f8 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 14, 2021
@parth-gr
build: create resources with k8s recommended labels
1e26d4f 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 14, 2021
@parth-gr
build: create resources with k8s recommended labels
fa8d2b4 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 14, 2021
@parth-gr
build: create resources with k8s recommended labels
89fc940 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 14, 2021
@parth-gr
build: create resources with k8s recommended labels
617ec9c 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 14, 2021
@parth-gr
build: create resources with k8s recommended labels
c2248fc 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 14, 2021
@parth-gr
build: create resources with k8s recommended labels
4cd58d5 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 14, 2021
@parth-gr
build: create resources with k8s recommended labels
e3441bd 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 14, 2021
@parth-gr
build: create resources with k8s recommended labels
494d73b 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 14, 2021
@parth-gr
build: create resources with k8s recommended labels
b823829 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 14, 2021
@parth-gr
build: create resources with k8s recommended labels
aa81ffc 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 14, 2021
@parth-gr
build: create resources with k8s recommended labels
ff12b42 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 14, 2021
@parth-gr
build: create resources with k8s recommended labels
63c10c4 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 15, 2021
@parth-gr
build: create resources with k8s recommended labels
55bb69f 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
@travisn travisn moved this from To do to In progress in v1.7 Sep 20, 2021
parth-gr added a commit to parth-gr/rook that referenced this issue Sep 21, 2021
@parth-gr
build: create resources with k8s recommended labels
ab4a694 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Oct 4, 2021
@parth-gr
build: create resources with k8s recommended labels
bd70a70 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Oct 4, 2021
@parth-gr
ceph: create rook resources with k8s recommended labels
7cbb7b9 
Adding Recommended Labels on the resources created by
Rook Operator
For better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Oct 4, 2021
@parth-gr
build: create resources with k8s recommended labels
8213722 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>

Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Oct 4, 2021
@parth-gr
ceph: create rook resources with k8s recommended labels
6a44cd6 
Adding Recommended Labels on the resources created by
Rook Operator
For better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Oct 8, 2021
@parth-gr
build: create resources with k8s recommended labels
4ad6b06 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>

Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Oct 8, 2021
@parth-gr
ceph: create rook resources with k8s recommended labels
2ccd074 
Adding Recommended Labels on the resources created by
Rook Operator
For better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Oct 11, 2021
@parth-gr
build: create resources with k8s recommended labels
0059da8 
Adding Recommended Labels on the rook resources,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>

Signed-off-by: parth-gr <paarora@redhat.com>
@travisn travisn removed the wontfix label Nov 2, 2021
parth-gr added a commit to parth-gr/rook that referenced this issue Nov 8, 2021
@parth-gr
build: create resources with k8s recommended labels
03ac2c7 
Use Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Nov 11, 2021
@parth-gr
build: create resources with k8s recommended labels
0647810 
Use Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Nov 16, 2021
@parth-gr
build: create resources with k8s recommended labels
9a13fee 
Use Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Nov 16, 2021
@parth-gr
build: create resources with k8s recommended labels
1f306ae 
Use Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Nov 16, 2021
@parth-gr
build: create resources with k8s recommended labels
afa2878 
Use Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Nov 19, 2021
@parth-gr
build: create resources with k8s recommended labels
3e8ec0a 
Use Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Nov 22, 2021
@parth-gr
build: create resources with k8s recommended labels
7d580ca 
Use Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Nov 30, 2021
@parth-gr
build: create resources with k8s recommended labels
492d4ca 
Use Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Dec 1, 2021
@parth-gr
build: create resources with k8s recommended labels
ea9c66c 
Use Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>

core: create rook resources with k8s recommended labels

Adding Recommended Labels on the resources created by rook,
for better visuals and management of k8s object

Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Dec 1, 2021
@parth-gr
core: create rook resources with k8s recommended labels
de5b3d2 
Adding Recommended Labels on the resources created by rook
and using Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Dec 1, 2021
@parth-gr
core: create rook resources with k8s recommended labels
37d5604 
Adding Recommended Labels on the resources created by rook
and using Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Dec 2, 2021
@parth-gr
core: create rook resources with k8s recommended labels
c9d157f 
Adding Recommended Labels on the resources created by rook
and using Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Dec 2, 2021
@parth-gr
core: create rook resources with k8s recommended labels
1343f5b 
Adding Recommended Labels on the resources created by rook
and using Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Dec 2, 2021
@parth-gr
core: create rook resources with k8s recommended labels
5e520f8 
Adding Recommended Labels on the resources created by rook
and using Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Dec 2, 2021
@parth-gr
core: create rook resources with k8s recommended labels
2c2e743 
Adding Recommended Labels on the resources created by rook
and using Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
@travisn travisn removed this from Review in progress in v1.7 Dec 2, 2021
@travisn travisn added this to To do in v1.8 via automation Dec 2, 2021
@travisn travisn moved this from To do to Blocking Release in v1.8 Dec 2, 2021
parth-gr added a commit to parth-gr/rook that referenced this issue Dec 6, 2021
@parth-gr
core: create rook resources with k8s recommended labels
d972d01 
Adding Recommended Labels on the resources created by rook
and using Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>

Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Dec 6, 2021
@parth-gr
core: create rook resources with k8s recommended labels
a07c2b2 
Adding Recommended Labels on the resources created by rook
and using Recommended Labels in the helm chart,
for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Dec 7, 2021
@parth-gr
core: create rook resources with k8s recommended labels
571f59e 
    Adding Recommended Labels on the resources created by rook
    and using Recommended Labels in the helm chart,
    for better visuals and management of k8s object

    Closes: rook#8400
    Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Dec 7, 2021
@parth-gr
core: create rook resources with k8s recommended labels
d3151c7 
    Adding Recommended Labels on the resources created by rook
    and using Recommended Labels in the helm chart,
    for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Dec 7, 2021
@parth-gr
core: create rook resources with k8s recommended labels
0a86d26 
    Adding Recommended Labels on the resources created by rook
    and using Recommended Labels in the helm chart,
    for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
v1.8 automation moved this from Blocking Release to Done Dec 7, 2021
mergify bot pushed a commit that referenced this issue Dec 7, 2021
@parth-gr
core: create rook resources with k8s recommended labels
f8a7c5b 
    Adding Recommended Labels on the resources created by rook
    and using Recommended Labels in the helm chart,
    for better visuals and management of k8s object

Closes: #8400
Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit 0a86d26)
parth-gr added a commit to parth-gr/rook that referenced this issue Feb 22, 2022
@parth-gr
core: create rook resources with k8s recommended labels
c37673e 
    Adding Recommended Labels on the resources created by rook
    and using Recommended Labels in the helm chart,
    for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Feb 22, 2022
@parth-gr
core: create rook resources with k8s recommended labels
dae0389 
    Adding Recommended Labels on the resources created by rook
    and using Recommended Labels in the helm chart,
    for better visuals and management of k8s object

Closes: rook#8400
Signed-off-by: parth-gr <paarora@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parth-gr parth-gr

Labels
feature
Projects
No open projects
v1.8
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: create rook resources with k8s recommended labels parth-gr/rook
4 participants
@leseb @travisn @TomHellier @parth-gr