Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8sutil: change all helper functions signatures to accept a context.Context #8700

Closed
leseb opened this issue Sep 13, 2021 · 2 comments
Closed

k8sutil: change all helper functions signatures to accept a context.Context #8700

leseb opened this issue Sep 13, 2021 · 2 comments
Labels
feature
Projects
v1.8

Comments

@leseb
Copy link
Member

leseb commented Sep 13, 2021 •
edited

In the k8sutil package, each function creates a context.TODO(), this is not needed anymore since each caller has a context that can be passed on.

Follow up from #8607
@leseb leseb added the feature label Sep 13, 2021
@leseb leseb added this to To do in v1.8 via automation Sep 13, 2021
@leseb leseb added the beginner label Sep 13, 2021
@parth-gr parth-gr mentioned this issue Oct 26, 2021
Closed
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

This was referenced Nov 13, 2021
Merged
Merged
Merged
Merged
Merged
@leseb leseb removed the wontfix label Nov 15, 2021
This was referenced Dec 11, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@y1r
Copy link
Contributor

y1r commented Dec 11, 2021

I think I've finished this issue by above PRs.

@leseb leseb moved this from To do to Review in progress in v1.8 Dec 13, 2021
@leseb leseb closed this as completed Dec 13, 2021
v1.8 automation moved this from Review in progress to Done Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
No open projects
v1.8
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leseb @y1r @parth-gr