doc: fix cephfs-mirror documentation #8732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
force-pushed
the
cephfs-mirror-doc
branch
from
30e158a
to
2bc5571
Compare
BlaineEXE
approved these changes
Sep 16, 2021
travisn
requested changes
Sep 16, 2021
| @@ -26,74 +27,19 @@ metadata: | |||
| namespace: rook-ceph | |||
| ``` | |||
There was a problem hiding this comment.
How about if this doc adds a link back to the filesystem topic for setting up the mirroring config/peers? Otherwise it is difficult to find how to configure.
leseb
force-pushed
the
cephfs-mirror-doc
branch
from
2bc5571
to
40ffab5
Compare
The steps to configure the peers are detailed in the CephFilesystem section. Only the CephFilesystem is holding the peer configuration, not the CephFilesystemMirror which only controls the bootstrap of the daemon. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
cephfs-mirror-doc
branch
from
40ffab5
to
fd28497
Compare
travisn
approved these changes
Sep 17, 2021
leseb
added a commit
that referenced
this pull request
Sep 20, 2021
doc: fix cephfs-mirror documentation (backport #8732)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
The steps to configure the peers are detailed in the CephFilesystem
section. Only the CephFilesystem is holding the peer configuration, not
the CephFilesystemMirror which only controls the bootstrap of the
daemon.
Signed-off-by: Sébastien Han seb@redhat.com
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.